Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Consistently use PUT instead of PATCH in v2 #6995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(router): Consistently use PUT instead of PATCH in v2 #6995

wants to merge 1 commit into from

Conversation

AnuthaDev
Copy link
Contributor

@AnuthaDev AnuthaDev commented Jan 6, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Unify the HTTP method for v2 endpoints to PUT

  • v2/payment-methods/{id}/update-saved-payment-method
  • v2/profiles/{id}/activate-routing-algorithm
  • v2/profiles/{id}/fallback-routing
  • v2/profiles/{id}/deactivate-routing-algorithm

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #6994

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@AnuthaDev AnuthaDev added A-core Area: Core flows api-v2 labels Jan 6, 2025
@AnuthaDev AnuthaDev self-assigned this Jan 6, 2025
@AnuthaDev AnuthaDev requested review from a team as code owners January 6, 2025 10:44
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 6, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  api-reference-v2/api-reference/payment-methods/payment-method--update.mdx Unsupported file format
  api-reference-v2/api-reference/profile/profile--activate-routing-algorithm.mdx Unsupported file format
  api-reference-v2/api-reference/profile/profile--deactivate-routing-algorithm.mdx Unsupported file format
  api-reference-v2/api-reference/profile/profile--update-default-fallback-routing-algorithm.mdx Unsupported file format
  api-reference-v2/openapi_spec.json  0% smaller
  crates/openapi/src/routes/payment_method.rs  0% smaller
  crates/openapi/src/routes/profile.rs  0% smaller
  crates/router/src/routes/app.rs  0% smaller
  cypress-tests-v2/cypress/support/commands.js  0% smaller

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AnuthaDev AnuthaDev

Labels
A-core Area: Core flows api-v2 M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistently use PUT instead of PATCH for v2 Update endpoints
1 participant
@AnuthaDev